Re: [PATCH] igafb: use framebuffer_alloc() to allocate fb_info struct
flat view
From: Sam Ravnborg <hidden>
Date: 2009-05-04 17:51:09
Also in:
sparclinux
Hi Krzysztof.
quoted hunk ↗ jump to hunk
diff -urp linux-orig/drivers/video/igafb.c linux-2.6.30/drivers/video/igafb.c--- linux-orig/drivers/video/igafb.c 2008-08-09 05:09:03.000000000 +0200 +++ linux-2.6.30/drivers/video/igafb.c 2009-05-04 00:14:28.000000000 +0200@@ -395,17 +395,16 @@ int __init igafb_init(void) /* We leak a reference here but as it cannot be unloaded this is fine. If you write unload code remember to free it in unload */ - size = sizeof(struct fb_info) + sizeof(struct iga_par) + sizeof(u32)*16; + size = sizeof(struct iga_par) + sizeof(u32)*16; - info = kzalloc(size, GFP_ATOMIC); + info = framebuffer_alloc(size, &pdev->dev);
While you are toucing this file it would be nice with a follow-up patch that tabbified all of the file. Today it looks like a mixture of tab and space used for indent. checking the original file... OK - it looks like the original file consistently used space for indent and only fixes uses tabs. Sam