Re: [PATCH] initialize fb_info->lock mutex in the framebuffer_alloc()

On Sun, May 3, 2009 at 23:30, Krzysztof Helt [off-list ref] wrote:

From: Krzysztof Helt <redacted>

The fb_info->lock mutex should be initialized inside
the framebuffer_alloc() function. Otherwise, someone
may call a fb layer function which indirectly uses uninitialized
mutex.
Move initialization of the mutex from the register_framebuffer()
to framebuffer_alloc().

This may cause problems for drivers which do not use
the framebuffer_alloc() to allocate the fb_info structure.
Convert the two last drivers to use the framebuffer_alloc().

diff -urp linux-orig/drivers/video/igafb.c linux-2.6.30/drivers/video/igafb.c
diff -urp linux-orig/drivers/video/offb.c linux-2.6.30/drivers/video/offb.c

Are these really the only 2 remaining ones? What about amifb and atafb
(from the top
of my head)?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

------------------------------------------------------------------------------
Register Now & Save for Velocity, the Web Performance & Operations 
Conference from O'Reilly Media. Velocity features a full day of 
expert-led, hands-on workshops and two days of sessions from industry 
leaders in dedicated Performance & Operations tracks. Use code vel09scf 
and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf