Re: [PATCH 08/15] powerpc/cell: Extract duplicated IOPTE_* to <asm/iommu.h>
From: Geert Uytterhoeven <hidden>
Date: 2009-05-11 07:24:58
Also in:
linuxppc-dev, lkml
On Sun, 10 May 2009, Christoph Hellwig wrote:
On Fri, May 08, 2009 at 04:01:17PM +0200, Geert Uytterhoeven wrote:quoted
+/* Cell page table entries */ +#define IOPTE_PP_W 0x8000000000000000ul /* protection: write */ +#define IOPTE_PP_R 0x4000000000000000ul /* protection: read */ +#define IOPTE_M 0x2000000000000000ul /* coherency required */ +#define IOPTE_SO_R 0x1000000000000000ul /* ordering: writes */ +#define IOPTE_SO_RW 0x1800000000000000ul /* ordering: r & w */ +#define IOPTE_RPN_Mask 0x07fffffffffff000ul /* RPN */ +#define IOPTE_H 0x0000000000000800ul /* cache hint */ +#define IOPTE_IOID_Mask 0x00000000000007fful /* ioid */If this is in a global header it should probably have a CELL_ prefix.
Fair enough; I'll use CBE_, as that's shorter and used for the other definitions in arch/powerpc/include/asm/cell-*.h, too. With kind regards, Geert Uytterhoeven Software Architect Techsoft Centre Technology and Software Centre Europe The Corporate Village � Da Vincilaan 7-D1 � B-1935 Zaventem � Belgium Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: Geert.Uytterhoeven@sonycom.com Internet: http://www.sony-europe.com/ A division of Sony Europe (Belgium) N.V. VAT BE 0413.825.160 � RPR Brussels Fortis � BIC GEBABEBB � IBAN BE41293037680010