Re: [Linux-fbdev-devel] [PATCH] vga16fb: fix color component length for pseudocolor modes
From: Krzysztof Helt <hidden>
Date: 2009-04-01 17:57:37
Also in:
lkml
On Tue, 31 Mar 2009 00:05:24 +0200 Michal Januszewski [off-list ref] wrote:
quoted hunk ↗ jump to hunk
vga16fb incorrectly sets the length of the color fields to 6 or 2 bits for PSEUDOCOLOR modes, for which either 8 or 4 bits are used per pixel. Fix this by setting the length to 8 or 4, respectively. Signed-off-by: Michal Januszewski <spock@gentoo.org> ---diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c index 5b29389..50033b9 100644 --- a/drivers/video/vga16fb.c +++ b/drivers/video/vga16fb.c@@ -506,7 +506,7 @@ static int vga16fb_check_var(struct fb_var_screeninfo *var, var->red.offset = var->green.offset = var->blue.offset = var->transp.offset = 0; var->red.length = var->green.length = var->blue.length = - (par->isVGA) ? 6 : 2; + (par->isVGA) ? 8 : 4; var->transp.length = 0; var->activate = FB_ACTIVATE_NOW; var->height = -1;
There is the second place to change in the vga16fb_probe(). Regards, Krzysztof ---------------------------------------------------------------------- Internetowe dowcipy na 1 kwietnia! Sprawdz! ;) http://link.interia.pl/f20f4