Thread (4 messages) 4 messages, 3 authors, 2009-02-15

Re: [PATCH 2/2] cirrusfb: use 5-6-5 RGB for 16bpp mode

From: Geert Uytterhoeven <hidden>
Date: 2009-02-15 11:59:08

On Sat, Feb 14, 2009 at 18:52, Krzysztof Helt [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Krzysztof Helt <redacted>

Use the 5-6-5 RGB mode instead of the 5-5-5 mode
at 16bpp depth.
It fixes colors in the 16bpp modes on Cirrus
Laguna chips.

Signed-off-by: Krzysztof Helt <redacted>
---
 drivers/video/cirrusfb.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/video/cirrusfb.c b/drivers/video/cirrusfb.c
index c98efd0..bf3d9c3 100644
--- a/drivers/video/cirrusfb.c
+++ b/drivers/video/cirrusfb.c
@@ -499,12 +499,12 @@ static int cirrusfb_check_var(struct fb_var_screeninfo *var,
                       var->green.offset = -3;
                       var->blue.offset = 8;
               } else {
-                       var->red.offset = 10;
+                       var->red.offset = 11;
                       var->green.offset = 5;
                       var->blue.offset = 0;
               }
               var->red.length = 5;
-               var->green.length = 5;
+               var->green.length = 6;
               var->blue.length = 5;
               break;
@@ -1180,7 +1180,7 @@ static int cirrusfb_set_par_foo(struct fb_info *info)
               /* pixel mask: pass-through all planes */
               WGen(cinfo, VGA_PEL_MSK, 0xff);
 #ifdef CONFIG_PCI
-               WHDR(cinfo, 0xc0);      /* Copy Xbh */
+               WHDR(cinfo, 0xc1);      /* Copy Xbh */
 #elif defined(CONFIG_ZORRO)
               /* FIXME: CONFIG_PCI and CONFIG_ZORRO may be defined both */
               WHDR(cinfo, 0xa0);      /* hidden dac reg: nothing special */
Does this need a similar or other change to cinfo for the Zorro case?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help