Re: [Linux-fbdev-devel] [PATCH 6/15] sm501fb: check fb_alloc_cmap return value and handle failure properly
From: Krzysztof Helt <hidden>
Date: 2009-02-09 16:53:17
Also in:
lkml
On Sat, 7 Feb 2009 12:14:48 -0500 Andres Salomon [off-list ref] wrote:
Signed-off-by: Andres Salomon <redacted> ---
Acked-by: Krzysztof Helt <redacted>
quoted hunk ↗ jump to hunk
drivers/video/sm501fb.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)diff --git a/drivers/video/sm501fb.c b/drivers/video/sm501fb.c index dcd9879..eb5d73a 100644 --- a/drivers/video/sm501fb.c +++ b/drivers/video/sm501fb.c@@ -1525,7 +1525,10 @@ static int sm501fb_init_fb(struct fb_info *fb, } /* initialise and set the palette */ - fb_alloc_cmap(&fb->cmap, NR_PALETTE, 0); + if (fb_alloc_cmap(&fb->cmap, NR_PALETTE, 0)) { + dev_err(info->dev, "failed to allocate cmap memory\n"); + return -ENOMEM; + } fb_set_cmap(&fb->cmap, fb); ret = (fb->fbops->fb_check_var)(&fb->var, fb);-- 1.5.6.5