Re: [Linux-fbdev-devel] [PATCH 1/2] atyfb: fix CONFIG_ namespace violations
From: Ville Syrjälä <syrjala@sci.fi>
Date: 2009-02-03 11:06:45
Also in:
lkml
On Tue, Feb 03, 2009 at 09:09:38AM +0100, Geert Uytterhoeven wrote:
On Mon, 2 Feb 2009, Randy Dunlap wrote:quoted
--- linux-2.6.29-rc3-git3.orig/drivers/video/aty/atyfb_base.c +++ linux-2.6.29-rc3-git3/drivers/video/aty/atyfb_base.c@@ -135,7 +135,7 @@ #if defined(CONFIG_PM) || defined(CONFIG_PMAC_BACKLIGHT) || \ defined (CONFIG_FB_ATY_GENERIC_LCD) || defined(CONFIG_FB_ATY_BACKLIGHT) static const u32 lt_lcd_regs[] = { - CONFIG_PANEL_LG, + CNFG_PANEL_LG,These were the official names as used in the ATI docs. After these changes, you can no longer easily grep for them. Perhaps it's better to prefix everything with ATI_? yes, I know it's more work (for the writer), but we want to optimize for the reader, right?
That would be my preference as well. -- Ville Syrjälä syrjala@sci.fi http://www.sci.fi/~syrjala/