Hi Jaya,

On Sat, Jan 17, 2009 at 9:21 PM, Jaya Kumar [off-list ref] wrote:

Hi Magnus, fbdev friends,

As discussed yesterday, this is an attempt to convert pagelist use
in defio over to pagemap. If everyone is okay with this, then we will
also need to convert over xen-pvfb, sh and any other drivers using
defio. Let me know your thoughts.

This is much better. But I really think you should make use of the
optimized functions in asm/bitops.h and linux/bitmap.h.

If you use the atomic versions of the bitop set (set_bit() instead of
__set_bit()) then there is no need for the mutex in
fb_defio_set_pagemap() - the entire function can maybe be reduced into
a single set_bit().

Also, in fb_deferred_io_work() you may want to switch to use the
find_first_bit() and find_next_bit() to figure out which pages to
clean.

On top of this, it would be great to have another tile based bitmap. I
have no time to hack on that now, but I'll keep it high on my todo
list. =)

Cheers,

/ magnus

------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword