Re: [PATCH 03/05] video: deferred io sys helpers - hecuba / n411

On Mon, Dec 22, 2008 at 2:58 PM, Paul Mundt [off-list ref] wrote:

On Mon, Dec 22, 2008 at 02:53:01PM +0900, Magnus Damm wrote:

quoted

From: Magnus Damm <redacted>

Change the hecubafb driver and the n411 code to use the new shared sys
helpers. This allows us to remove some duplicated code. In the future
this driver can setup the "sysdelay" value to delay flushing.

While at it, convert space to tabs for the n411 kconfig entry.

Signed-off-by: Magnus Damm <redacted>
---

 drivers/video/Kconfig    |   17 +++------
 drivers/video/hecubafb.c |   86 ++--------------------------------------------
 2 files changed, 11 insertions(+), 92 deletions(-)

--- 0050/drivers/video/Kconfig
+++ work/drivers/video/Kconfig        2008-12-22 14:06:31.000000000 +0900

@@ -712,17 +712,12 @@ config FB_EFI
        using the EFI framebuffer as your console.

 config FB_N411
-       tristate "N411 Apollo/Hecuba devkit support"
-       depends on FB && X86 && MMU
-       select FB_SYS_FILLRECT
-       select FB_SYS_COPYAREA
-       select FB_SYS_IMAGEBLIT
-       select FB_SYS_FOPS
-       select FB_DEFERRED_IO
-       select FB_HECUBA
-       help
-         This enables support for the Apollo display controller in its
-         Hecuba form using the n411 devkit.
+     tristate "N411 Apollo/Hecuba devkit support"
+     depends on FB && X86 && MMU
+     select FB_HECUBA
+     help
+       This enables support for the Apollo display controller in its
+       Hecuba form using the n411 devkit.

This drops the FB_DEFERRED_IO select.. FB_HECUBA has a depends on, but
nothing else will select it.

Uhm, right. FB_HECUBA should select instead of depend. Thanks for checking!

/ magnus