[PATCH] ARM: OMAP: Remove broken LCD driver for SX1 (Re: Please fix lcd_sx1.c)

* Tony Lindgren [off-list ref] [081124 13:21]:

* Russell King - ARM Linux [off-list ref] [081123 08:58]:

quoted

On Sun, Nov 23, 2008 at 04:46:18PM +0000, Russell King - ARM Linux wrote:

quoted

To me, it looks like this driver was tossed over into mainline without
any thought - it has never been in a buildable state.  Please fix or
remove this driver from mainline.

Actually, it was buildable, until this commit:

commit b4b58f5834a023dab67201db9a626bef07bb200c
Author: Chandra Shekhar [off-list ref]
Date:   Wed Oct 8 10:01:39 2008 +0300

    ARM: OMAP: Allocate McBSP devices dynamically
    
    Based on Chandra's earlier patches in linux-omap tree.
    
    Note that omap1_mcbsp_check and omap2_mcbsp_check are no longer
    needed as there's now omap_mcbsp_check_valid_id() defined.
    
    Also some functions can now be marked __init.
    
    Signed-off-by: Chandra Shekhar [off-list ref]
    Signed-off-by: Tony Lindgren [off-list ref]

which means it's a regression and therefore needs fixing before 2.6.28.

Will send you a patch for this today.

Well looks like there's no way I can fix this. I don't have the
hardware, so people using sx1 would need to fix this.

Looks like the driver is attempting to use SPI mode, but is doing it
in a different way compared to mcbsp.c.

I'm suggesting the following patch unless somebody can do a real patch
for this over next few days.

Regards,

Tony