On Wed, 15 Oct 2008 16:05:20 -0700
Andrew Morton [off-list ref] wrote:

On Sat, 6 Sep 2008 12:41:14 +0200 (CEST)
Geert Uytterhoeven [off-list ref] wrote:

quoted

On Sat, 6 Sep 2008, Krzysztof Helt wrote:

quoted

On Sat, 6 Sep 2008 10:37:27 +0200 (CEST)
Geert Uytterhoeven [off-list ref] wrote:

quoted

On Fri, 5 Sep 2008, Krzysztof Helt wrote:

quoted

From: Krzysztof Helt <redacted>

Fix debug printk types mismatch after
my earlier changes.

#define DPRINTK(fmt, args...)	pr_debug("%s: " fmt, __func__ , ## args)

unconditionally, so you always catch these?

I do not understand. Is it a suggestion to make DPRINTK unconditional?

Yes.

quoted

Then, the amount of information printed should be trimmed down. It is excessive now.

Please not that pr_debug() gets optimized away if DEBUG is not defined
( i.e. it doesn't cause excessive output), while it still performs
printf()-style format checking.

hm.  No change occurred as a result of this discussion.

I guess none was really needed - I'll go ahead with the patch.

I have made the change of the driver to use the dev_dbg/dev_err() functions some time ago.
However, the real life  sucked me into I have not tested this. I'll return to this when 
I sort out non-Linux stuff. I am slowly recovering and trying to go through pile of unanswered 
emails/bugs reported to my patches.

Take care,
Krzysztof

----------------------------------------------------------------------
Konkurs! Wygraj m.in. telewizor LCD!
Sprawdz >> http://link.interia.pl/f1f52 


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/