On Donnerstag, 4. September 2008, krzysztof.h1@poczta.fm wrote:

quoted

On Mittwoch, 3. September 2008, Krzysztof Helt wrote:

quoted

On Tue,  2 Sep 2008 13:24:51 +0200

Sascha Hauer [off-list ref] wrote:

quoted

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/video/imxfb.c |   70
+++++++++++++++++++++++------------------------- 1 files changed, 34
insertions(+), 36 deletions(-)

Acked-by: Krzysztof Helt <redacted>

One offtopic comment: do you really want the FBINFO_READS_FAST set?

It means that the driver prefer copyarea to imgblit function. It is

Did you ever get the framework to use the copyarea function the driver
provides? I tried it several times and this function was never called.
Independent from any flags I set or clear.

jbe

I do not have atmel hardware to test.

Its not architecture specific.

I did used the copyarea on some other drivers (tridentfb, pm2fb).

How did you use them?

The tdfxfb driver uses now copyarea function for console scrolling.

Are you sure, this function will be called? I wrote two drivers for ARM and 
x86 graphics hardware and provide a copyarea function for both of them. The 
console framework ignores both. Only the fillrect and imageblit function is 
used from the frambuffer console code.

In driver/video/console/fbcon.c I always fail in function fbcon_scroll(). 
The "dir" switch/case never reaches one of the "switch (p->scrollmode)" 
statements.

jbe

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/