Re: [PATCH 1/2] atmel_lcdfb: Set ypanstep to 1 and enable y-panning on AT91
flat view
From: Andrew Morton <akpm@linux-foundation.org>
Date: 2008-08-08 20:42:29
On Fri, 8 Aug 2008 14:46:43 +0200 Stanislaw Gruszka [off-list ref] wrote:
Panning in the y-direction can be done by simply changing the DMA base address. This code is already in place, but FBIOPAN_DISPLAY will currently fail because ypanstep is 0. Set ypanstep to 1 to indicate that we do support y-panning and also set the necessary acceleration flags on AT91 (AVR32 already have them.) Signed-off-by: Haavard Skinnemoen <redacted>
problems... a) Neither of these changelogs communicate the seriousness of the problem which is being fixed, nor the benefit of the change. So when I go through my usual "do we need this in 2.6.27? 2.6.26? 2.6.25?" exercise, I don't have enough information to be able to tell. b) The second patch was wordwrapped by your email client. I fixed that. c) The authorship/signoff is confusing. The patch is From:you and signed-off-by:Haavard but is missing your signed-off-by:. Who wrote the patches? If it was you then all we're missing is your signed-off-by:. If it was Haavard then you should have had his From: line at the start of the chagnelog to indicate this. Either way, it should have had your signed-off-by:, because you were in the delivery path. If Haavard did not participate in the development and was not in the delivery path then his signed-off-by: was inappropriate, and an acked-by: or tested-by: or reviewed-by: would be better. ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/