Re: [PATCH] fix scrolling after logo is cleared

Started by unknown sender on Jul 31, 2008

open the first message on its own page

Message details and related content
On Wed, 28 May 2008 22:53:37 +0200 Krzysztof Helt [off-list ref]
wrote:
quoted
From: Krzysztof Helt <redacted>

If the 'clear' command is used on the frame buffer
with a logo the upper area is filled by few lines but
not scrolled anymore.
Fix this by removing the protected area for the logo
if any part of the logo is cleared.

Signed-off-by: Krzysztof Helt <redacted>
---

diff -urp linux-rc2/drivers/video/console/fbcon.c
linux-new/drivers/video/console/fbcon.c
quoted
--- linux-rc2/drivers/video/console/fbcon.c	2008-05-12
18:16:23.193553990 +0200
quoted
+++ linux-new/drivers/video/console/fbcon.c	2008-05-26
21:10:17.592997192 +0200
quoted
@@ -1312,6 +1310,9 @@ static void fbcon_clear(struct vc_data *
 	if (!height || !width)
 		return;
 
+	if (sy < vc->vc_top && vc->vc_top == logo_lines)
+		vc->vc_top = 0;
+
 	/* Split blits that cross physical y_wrap boundary */
 
 	y_break = p->vrows - p->yscroll;
So I'm trolling linux-fbdev-devel for lost patches and I come across
this one.

It is still good?  If so, do you think it should be in 2.6.27?  And
earlier?
I forgot this one. I sent it to get a feedback from other fbdev devs but forgot to resend it with cc to you.

Yes, it is  still good.  It is side effect of the tridentfb testing.

Regards,
Krzysztof

----------------------------------------------------------------------
Najciekawsze miejsca w Polsce i na swiecie!
Zobacz >>> http://link.interia.pl/f1e60


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help