Re: [Linux-fbdev-devel] [PATCH 6/7] drivers/video: Release mutex in error handling code
From: Krzysztof Helt <hidden>
Date: 2008-07-22 04:14:36
Also in:
kernel-janitors, lkml
From: Krzysztof Helt <hidden>
Date: 2008-07-22 04:14:36
Also in:
kernel-janitors, lkml
On Mon, 21 Jul 2008 09:58:55 +0200 (CEST) Julia Lawall [off-list ref] wrote:
From: Julia Lawall <redacted> The mutex is released on a successful return, so it would seem that it should be released on an error return as well. The semantic patch finds this problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @@ expression l; @@ mutex_lock(l); ... when != mutex_unlock(l) when any when strict ( if (...) { ... when != mutex_unlock(l) + mutex_unlock(l); return ...; } | mutex_unlock(l); ) // </smpl> Signed-off-by: Julia Lawall <redacted> ---
Acked-by: Krzysztof Helt <redacted> ---------------------------------------------------------------------- Partyjka w Chinczyka? Graj >>> http://link.interia.pl/f1e67