Re: [RFC 2.6.26-rc3 01/10] pxafb: fix ifdef for command line option handling
From: Eric Miao <hidden>
Date: 2008-06-13 01:22:52
Krzysztof Helt wrote:
On Thu, 12 Jun 2008 12:59:12 -0400 Jaya Kumar [off-list ref] wrote:quoted
This bug was found and fixed by Lothar Wassmann. Previously, the use of ifndef CONFIG_MODULES made it such that pxafb command line option parsing was dependent on whether the kernel was built with module support. The ifndef should be MODULE so that parsing is dependent only on whether the driver is built-in or not. Signed-off-by: Jaya Kumar <redacted> --- drivers/video/pxafb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/drivers/video/pxafb.c b/drivers/video/pxafb.c index 274bc93..dd013f3 100644 --- a/drivers/video/pxafb.c +++ b/drivers/video/pxafb.c@@ -1586,7 +1586,7 @@ static int __init pxafb_parse_options(struct device *dev, char *options) static char g_options[256] __devinitdata = ""; -#ifndef CONFIG_MODULES +#ifndef MODULE static int __devinit pxafb_setup_options(void) { char *options = NULL;--Acked-by: Krzysztof Helt <redacted> Eric, Can you review and ack at least few first patches from this set? Jaya redoes this set for the third or fourth time and every time he redoes it I have to review the whole set again. If you can ack few first patches, he can upload them into RMK's patch system and redoes only a part of the set next time. Thank you in advance.
Acked-by: Eric Miao <redacted>
Krzysztof ---------------------------------------------------------------------- Jeste¶ Polakiem i mieszkasz za granica? Sprawdz! kliknij >>> http://link.interia.pl/f1e38 ------------------------------------------------------------------------ ------------------------------------------------------------------- List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel FAQ: http://www.arm.linux.org.uk/mailinglists/faq.php Etiquette: http://www.arm.linux.org.uk/mailinglists/etiquette.php
------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ Linux-fbdev-devel mailing list Linux-fbdev-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel