Re: [RFC 2.6.26-rc3 1/7] pxafb: module unloading support

On Tue, Jun 10, 2008 at 12:44 AM, Eric Miao [off-list ref] wrote:

Lothar Waßmann wrote:

quoted

Jaya Kumar wrote:

quoted

@@ -1587,7 +1587,7 @@ static int __init pxafb_parse_options(struct device *dev, char *options)
 static char g_options[256] __devinitdata = "";

 #ifndef CONFIG_MODULES

           ^^^^^^^^^^^^^^

quoted

-static int __devinit pxafb_setup_options(void)
+static int __init pxafb_setup_options(void)

That should be '#ifndef MODULE'.
Otherwise support for cmdline options for the built-in driver will
only be enabled if the kernel is compiled without module support.

Yes, indeed. It requires another fix patch for this.

Hi Eric, Lothar,

That CONFIG_MODULES is from the pxafb code. It is not part of the
changes that I made to pxafb.

Since it is a small ifndef change, I'll go ahead and follow your
suggestion and add a separate patch to fix that issue and add it to
this series of patches. That said, I think I would like to keep this
patchset focused on resolving the am200epd/pxafb sharing issues rather
than other issues that may be there in pxafb.

Thanks,
jaya

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php