Thread (4 messages) 4 messages, 2 authors, 2008-05-16

Re: [PATCH] tridentfb: acceleration code improvements

From: Andrew Morton <akpm@linux-foundation.org>
Date: 2008-05-16 05:16:27

On Fri, 16 May 2008 06:46:02 +0200 Krzysztof Helt [off-list ref] wrote:
On Thu, 15 May 2008 15:56:14 -0700
Andrew Morton [off-list ref] wrote:
quoted
On Wed, 14 May 2008 07:12:00 +0200
checkpatch whines:

ERROR: space required after that ',' (ctx:VxV)
(...)

How do you run the checkpatch? I am not getting these warning even with the "--strict" option (stock linux-2.6.26-rc2 kernel scripts). Do you have another version?
I'd like to have the same version as you.
doh.  -mm's update-checkpatchpl-to-version-019.patch is needed to pick
up this problem.
quoted
Also that macro is plain wrong:

	if (foo)
		debug(...);
	else
		something();

won't compile.  Using the do{...}while(0) thing or perhaps {(...)} will fix.
I'll fix it.
Cool.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft 
Defy all challenges. Microsoft(R) Visual Studio 2008. 
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help