Re: [PATCH 1/1 2.6.25] fbdev: bugfix for multiprocess defio
From: Jaya Kumar <hidden>
Date: 2008-05-05 07:23:11
On Wed, Apr 30, 2008 at 1:37 PM, Andrew Morton [off-list ref] wrote:
On Sun, 27 Apr 2008 22:01:40 -0400
Jaya Kumar [off-list ref] wrote:
> + /* we loop through the pagelist before adding in order
> + to keep the pagelist sorted */
> + list_for_each_entry(cur, &fbdefio->pagelist, lru) {
Did you consider using !list_empty(&page->lru) to avoid the linear search?Ah, no, I didn't think of that. I agree that checking list_empty would be far better. I'll redo the patch using that. Thanks, jaya ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone