Thread (3 messages) 3 messages, 2 authors, 2008-05-03

Re: [PATCH V7] [FB] Add the carmine FB driver.

From: Sebastian Siewior <hidden>
Date: 2008-05-03 06:01:35

* Andrew Morton | 2008-05-02 16:21:14 [-0700]:
On Fri, 2 May 2008 19:27:54 +0200
Sebastian Siewior [off-list ref] wrote:
quoted
+static const struct fb_videomode carmine_modedb[] = {
+	{
+		.name		= "640x480",
+		.xres		= 640,
+		.yres		= 480,
+		.pixclock	= 0,
+		.left_margin	= 0,
+		.right_margin	= 0,
+		.upper_margin	= 0,
+		.lower_margin	= 0,
+		.hsync_len	= 0,
+		.vsync_len	= 0,
+		.sync		= 0,
+		.vmode		= 0,
+		.flag		= 0,
+	}, {
+		.name		= "800x600",
+		.xres		= 800,
+		.yres		= 600,
+		.pixclock	= 0,
+	},
+};
The initialisations with zero here aren't needed - the compiler does it. 
Normally we omit them, but sometimes they can be nice for commentary
reasons.  A minor thing.
Removed

Sebastian

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help