Thread (3 messages) 3 messages, 3 authors, 2008-05-08

Re: [Linux-fbdev-devel] [PATCH 7/9] viafb: VIA Frame Buffer Device Driver

From: Krzysztof Helt <hidden>
Date: 2008-05-07 16:51:25
Also in: lkml

On Wed, 7 May 2008 19:09:44 +0800
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Joseph Chan <redacted>

diff -Nur a/drivers/video/via/viafbdev.h b/drivers/video/via/viafbdev.h
--- a/drivers/video/via/viafbdev.h	1969-12-31 19:00:00.000000000 -0500
+++ b/drivers/video/via/viafbdev.h	2008-04-29 04:27:46.000000000 -0400
@@ -0,0 +1,114 @@
(...)
+
+struct viafb_par {
+	struct fb_var_screeninfo var;
+	int bpp;
+	int hres;
+	int vres;
+	int linelength;
+	int vclk;		/*in MHz */
+
+	int vtotal;
+	int vdispend;
+	int vsyncstart;
+	int vsyncend;
+	int vblankstart;
+	int vblankend;
+
+	int htotal;
+	int hdispend;
+	int hsyncstart;
+	int hsyncend;
+	int hblankstart;
+	int hblankend;
+
+	int accel;		/* Acceleration Flags */
A random pick of "accel", "hblankstart" and "hblankend" shows that they are only set and never checked. Try to remove all unused fields here.

Regards,
Krzysztof

----------------------------------------------------------------------
Lepszy niz zakladki. 	
Kliknij >>> http://link.interia.pl/f1db1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help