Thread (3 messages) 3 messages, 2 authors, 2008-04-22

Re: [PATCH 3/3] atyfb: Fix 64 bits resources on 32 bits archs

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2008-04-22 22:26:35
Also in: linuxppc-dev, lkml

On Tue, 2008-04-22 at 19:43 +0400, Sergei Shtylyov wrote:
    Not sure what that change gives us -- this function mostly treats 'addr' 
as unsigned long (casting it to char/void *), ot compares it to 'unsigned 
long' 'base' variable -- which should be made 'resource_size_t' in its turn 
being assigned resource's start value.  So, this part of patch looks incomplete
(and yet I'm not sure if SPARC really needs all that)...
I just wanted to make sure both setup functions has the same prototype. 

I think sparc doesn't need fixing in there.

Ben.


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help