On Tue, 8 Apr 2008 12:07:27 +0800 "eric miao" [off-list ref] wrote:

+static int pxafb_smart_thread(void *arg)
+{
+	struct pxafb_info *fbi = (struct pxafb_info *) arg;

Please don't typecast when assigning a pointer to or from void*.

Reasons:

- It defeats typechecking: if someone later converts `arg' to a u8, they
  won't even get a compiler warning.

- Improved code readability.


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Register now and save $200. Hurry, offer ends at 11:59 p.m., 
Monday, April 7! Use priority code J8TLD2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone