Re: [PATCH 3/4] pxafb: move parallel LCD timing setup into dedicate function
From: Andrew Morton <akpm@linux-foundation.org>
Date: 2008-04-08 08:22:25
Also in:
lkml
On Tue, 8 Apr 2008 12:05:16 +0800 "eric miao" [off-list ref] wrote:
quoted hunk ↗ jump to hunk
@@ -636,61 +671,31 @@ static int pxafb_activate_var(structfb_var_screeninfo *var, printk(KERN_ERR "%s: invalid lower_margin %d\n", fbi->fb.fix.id, var->lower_margin); #endif + /* Update shadow copy atomically */ + local_irq_save(flags);
So this code will only ever work on uniprocessor machines? Is this a safe and reasonable assumption? ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Register now and save $200. Hurry, offer ends at 11:59 p.m., Monday, April 7! Use priority code J8TLD2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone