On Tue, 25 Mar 2008 16:27:17 -0500 York Sun [off-list ref] wrote:
quoted hunk ↗ jump to hunk
+#if defined(CONFIG_NOT_COHERENT_CACHE)
+unsigned int *coherence_data;
+phys_addr_t *coherence_data_phy;
+#endif
These identifiers are too general for use as global symbols. I'd suggest
renaming them to diu_coherence_data and diu_coherence_data_phy. Or make
them static - I didn't check.
I'll duck this version of the patches, as Scott's comments looked rather
substantial.
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace