On Sun, 16 Mar 2008, Stefan Bauer wrote:
quoted hunk ↗ jump to hunk
From: Stefan Bauer <redacted>
Commit eaa0ff15c30dc9799eb4d12660edb73aeb6d32c5 ("fix ! versus & precedence in
various places") introduced a regression in console switching when using
i810fb. Every 5th to 10th console switch causes 'pixel waste' - the same line
of multi-colored pixels repeated over the whole screen.
This reverts eaa0ff1 for i810_main.c.
Signed-off-by: Stefan Bauer <redacted>
Cc: Antonino Daplas <redacted>
---
As I'm not subscribed to the LKML, please CC me, thanks.
--- linux-2.6/drivers/video/i810/i810_main.c.orig
+++ linux-2.6/drivers/video/i810/i810_main.c
@@ -1476,7 +1476,7 @@ static int i810fb_cursor(struct fb_info
struct i810fb_par *par = info->par;
u8 __iomem *mmio = par->mmio_start_virtual;
- if (!(par->dev_flags & LOCKUP))
+ if (!par->dev_flags & LOCKUP)
return -ENXIO;
if (cursor->image.width > 64 || cursor->image.height > 64)
--
I think you need to add something to that line that avoids someone making
the same change as eaa0ff15c30dc9799eb4d12660edb73aeb6d32c5 some years down
the road.
Might I suggest using "((!par->dev_flags) & LOCKUP)"?
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh