Re: [PATCH 6/6] PM/FB/gxfb: add config option that allows disabling of VT switch during suspend

On Mon, 10 Mar 2008 23:28:18 +0100 "Rafael J. Wysocki" [off-list ref] wrote:

quoted

quoted

quoted

If so, that means extra #ifdef's sprinkled throughout the code.  Note
that most framebuffer drivers won't be supporting this, and those that
do will almost certainly always want vt switching turned off..

I don't think you need any ifdefs or config options at all, do you?  Just
add a new module parameter to this driver and some little interface into
the PM core which allows the driver to set no_vt_switch?

That's a possibility, but doesn't adding hooks into PM core for two
drivers (lxfb and gxfb) seems like overkill?  I also don't really see
anyone needing to switch back and forth between VT_SWITCH and
NO_VT_SWITCH other than to work around possible bugs in the register
save/restore code..

FWIW, I prefer the original .config option idea.

Please explain your reasoning?