Re: [PATCH] [Resend] fbcon : fix color generation for monochrome framebuffer
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2008-02-01 12:24:45
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2008-02-01 12:24:45
On Fri, 1 Feb 2008, Thomas Pfaff wrote:
On Thu, 31 Jan 2008, Andrew Morton wrote:quoted
On Mon, 28 Jan 2008 11:03:38 +0100 (CET)If the functions should be deinlined someone should decide where to put them. Since they must be exported i would avoid to put them into fbcon.c, this would lead to cross dependencies. I would suggest to put the prototype into <linux/fb.h> and the definition into fbcmap.c instead, but i am unsure whether they really belong there.
General note: functions in header files must be inline, else you get
multiple definitions of the same symbol.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/