Re: [PATCH] pxafb: Add missing code to support palette formats
From: eric miao <hidden>
Date: 2007-11-24 08:28:55
On Nov 23, 2007 7:26 PM, Hans J. Koch [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Subject: pxafb: Add missing code to support palette formats Date: Fri, 23 Nov 2007 10:33:24 +0100 From: Hans J Koch <redacted> A few lines of code are missing to support different palette formats in pxafb. This patch adds them, code was tested on PXA270. Signed-off-by: Hans J Koch <redacted> --- drivers/video/pxafb.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) Index: linux-2.6.24-rc/drivers/video/pxafb.c ===================================================================--- linux-2.6.24-rc.orig/drivers/video/pxafb.c 2007-11-2223:03:28.000000000 +0100 +++ linux-2.6.24-rc/drivers/video/pxafb.c 2007-11-22 23:43:07.000000000 +0100 @@ -745,8 +745,14 @@ fbi->reg_lccr1 = new_regs.lccr1; fbi->reg_lccr2 = new_regs.lccr2; fbi->reg_lccr3 = new_regs.lccr3; - fbi->reg_lccr4 = LCCR4 & (~LCCR4_PAL_FOR_MASK); - fbi->reg_lccr4 |= (fbi->lccr4 & LCCR4_PAL_FOR_MASK); + + if (((read_cpuid(CPUID_ID) >> 4) & 0x1f) == 0x11) { + /* PXA 27x only */ + fbi->reg_lccr4 = LCCR4 & (~LCCR4_PAL_FOR_MASK); + fbi->reg_lccr4 |= (fbi->lccr4 & LCCR4_PAL_FOR_MASK); + } else + fbi->reg_lccr4 = 0; +
I don't see what's wrong with the original code. Can you explain this a bit more? And there are already cpu_is_pxa27x() and friends in the kernel, so use those instead of your own please.
quoted hunk ↗ jump to hunk
set_hsync_time(fbi, pcd); local_irq_restore(flags);@@ -838,6 +844,8 @@ clk_enable(fbi->clk); /* Sequence from 11.7.10 */ + if (((read_cpuid(CPUID_ID) >> 4) & 0x1f) == 0x11) + LCCR4 = fbi->reg_lccr4; /* PXA 27x only */ LCCR3 = fbi->reg_lccr3; LCCR2 = fbi->reg_lccr2; LCCR1 = fbi->reg_lccr1;
Ditto.
------------------------------------------------------------------- List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel FAQ: http://www.arm.linux.org.uk/mailinglists/faq.php Etiquette: http://www.arm.linux.org.uk/mailinglists/etiquette.php
-- Cheers - eric ------------------------------------------------------------------- List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel FAQ: http://www.arm.linux.org.uk/mailinglists/faq.php Etiquette: http://www.arm.linux.org.uk/mailinglists/etiquette.php