From: Hans J. Koch <hidden> Date: 2007-11-23 11:28:39
Subject: pxafb: Add missing code to support palette formats
Date: Fri, 23 Nov 2007 10:33:24 +0100
From: Hans J Koch <redacted>
A few lines of code are missing to support different palette formats in
pxafb. This patch adds them, code was tested on PXA270.
Signed-off-by: Hans J Koch <redacted>
---
drivers/video/pxafb.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
Index: linux-2.6.24-rc/drivers/video/pxafb.c
===================================================================
From: eric miao <hidden> Date: 2007-11-24 08:28:55
On Nov 23, 2007 7:26 PM, Hans J. Koch [off-list ref] wrote:
quoted hunk
Subject: pxafb: Add missing code to support palette formats
Date: Fri, 23 Nov 2007 10:33:24 +0100
From: Hans J Koch <redacted>
A few lines of code are missing to support different palette formats in
pxafb. This patch adds them, code was tested on PXA270.
Signed-off-by: Hans J Koch <redacted>
---
drivers/video/pxafb.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
Index: linux-2.6.24-rc/drivers/video/pxafb.c
===================================================================
I don't see what's wrong with the original code. Can you explain this
a bit more?
And there are already cpu_is_pxa27x() and friends in the kernel, so
use those instead of your own please.
Am Sat, 24 Nov 2007 16:28:55 +0800
schrieb "eric miao" [off-list ref]:
On Nov 23, 2007 7:26 PM, Hans J. Koch [off-list ref] wrote:
quoted
Subject: pxafb: Add missing code to support palette formats
Date: Fri, 23 Nov 2007 10:33:24 +0100
From: Hans J Koch <redacted>
A few lines of code are missing to support different palette
formats in pxafb. This patch adds them, code was tested on PXA270.
Signed-off-by: Hans J Koch <redacted>
---
drivers/video/pxafb.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
Index: linux-2.6.24-rc/drivers/video/pxafb.c
===================================================================
I don't see what's wrong with the original code. Can you explain this
a bit more?
The patch fixes two problems:
1. Register LCCR4 exists on PXA27x only.
2. The original code never writes to LCCR4. It sets fbi->reg_lccr4 only.
And there are already cpu_is_pxa27x() and friends in the kernel, so
use those instead of your own please.
Right.
Thanks for your hints, Eric! Here's an updated version:
Subject: pxafb: Add missing code to support palette formats
Date: Fri, 23 Nov 2007 10:33:24 +0100
From: Hans J Koch <redacted>
A few lines of code are missing to support different palette formats in pxafb.
This patch adds them, code was tested on PXA270.
Signed-off-by: Hans J Koch <redacted>
---
drivers/video/pxafb.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
Index: linux-2.6.24-rc/drivers/video/pxafb.c
===================================================================
From: eric miao <hidden> Date: 2007-11-27 02:48:54
On Nov 26, 2007 9:58 PM, Hans-Jürgen Koch [off-list ref] wrote:
quoted hunk
Am Sat, 24 Nov 2007 16:28:55 +0800
schrieb "eric miao" [off-list ref]:
quoted
On Nov 23, 2007 7:26 PM, Hans J. Koch [off-list ref] wrote:
quoted
Subject: pxafb: Add missing code to support palette formats
Date: Fri, 23 Nov 2007 10:33:24 +0100
From: Hans J Koch <redacted>
A few lines of code are missing to support different palette
formats in pxafb. This patch adds them, code was tested on PXA270.
Signed-off-by: Hans J Koch <redacted>
---
drivers/video/pxafb.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
Index: linux-2.6.24-rc/drivers/video/pxafb.c
===================================================================
I don't see what's wrong with the original code. Can you explain this
a bit more?
The patch fixes two problems:
1. Register LCCR4 exists on PXA27x only.
2. The original code never writes to LCCR4. It sets fbi->reg_lccr4 only.
quoted
And there are already cpu_is_pxa27x() and friends in the kernel, so
use those instead of your own please.
Right.
Thanks for your hints, Eric! Here's an updated version:
Subject: pxafb: Add missing code to support palette formats
Date: Fri, 23 Nov 2007 10:33:24 +0100
From: Hans J Koch <redacted>
A few lines of code are missing to support different palette formats in pxafb.
This patch adds them, code was tested on PXA270.
Signed-off-by: Hans J Koch <redacted>
---
drivers/video/pxafb.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
Index: linux-2.6.24-rc/drivers/video/pxafb.c
===================================================================
it would be more appropriate to initialize fbi->lccr4 to '0' in
pxafb_init_fbinfo()
if it is pxa25x/pxa21x since fbi->lccr4 will be used to calculate the size and
format of the palette buffer while pxa25x/pxa21x support only 16-bit
palette _only_.
it is also possible no change made here to fbi->reg_lccr4 since the value
will not be guarded to be actually written if pxa25x/pxa21x
Anyway, I do think the issue is within the introduce of lccr4 in
previous patches.
There should be much clean patch to this issue, though.
--
Cheers
- eric
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Linux-fbdev-devel mailing list
Linux-fbdev-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel