pm2fb: corrects error values returned from probe function

Started by Krzysztof Helt on Oct 31, 2007

DORMANTno replies

open the first message on its own page

Message details and related content
From: Krzysztof Helt <redacted>

This patch fixes error values returned in some code branches
in the pm2fb_probe() function.

Signed-off-by: Krzysztof Helt <redacted>

---

This patch was done against the 2.6.24-rc1-git4 kernel.

diff -urp linux-ref/drivers/video/pm2fb.c linux-2.6.23/drivers/video/pm2fb.c
--- linux-ref/drivers/video/pm2fb.c	2007-10-28 08:31:16.883366340 +0100
+++ linux-2.6.23/drivers/video/pm2fb.c	2007-10-30 22:40:48.152286777 +0100
@@ -1684,10 +1684,12 @@ static int __devinit pm2fb_probe(struct 
 	if (!err || err == 4)
 		info->var = pm2fb_var;
 
-	if (fb_alloc_cmap(&info->cmap, 256, 0) < 0)
+	retval = fb_alloc_cmap(&info->cmap, 256, 0);
+	if (retval < 0)
 		goto err_exit_both;
 
-	if (register_framebuffer(info) < 0)
+	retval = register_framebuffer(info);
+	if (retval < 0)
 		goto err_exit_all;
 
 	printk(KERN_INFO "fb%d: %s frame buffer device, memory = %dK.\n",


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help