Thread (20 messages) flat view 20 messages, 4 authors, 2007-10-09

Re: [PATCH 6/6] Xilinxfb: add of_platform bus binding

From: Grant Likely <hidden>
Date: 2007-10-01 16:46:46
Also in: lkml

On 10/1/07, Akinobu Mita [off-list ref] wrote:
2007/10/2, Grant Likely [off-list ref]:
quoted
 static int __init
 xilinxfb_init(void)
 {
-       /*
-        * No kernel boot options used,
-        * so we just need to register the driver
-        */
+       int rc;
+       rc = xilinxfb_of_register();
+       if (rc)
+               return rc;
+
        return platform_driver_register(&xilinxfb_platform_driver);
Is it better to add error handling for platform_driver_register()?
Right, good catch.  I'll fix that

Thanks!
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help