On Sun, 2007-09-30 at 09:11 +0200, Geert Uytterhoeven wrote:

On Sun, 30 Sep 2007, Benjamin Herrenschmidt wrote:

quoted

quoted

Probably scripts/checkpatch.pl should be taught to complain about
`#undef DEBUG'.

Why ? Whenever I have things that are #ifdef DEBUG in the file (such as
dev_dbg statements), I always leave a #undef DEBUG statement at the top.

Because it overrides a -DDEBUG on the build command line.

Hrm... ok, I never play with the commandline :-)

quoted

That way, I know I can enable debug in that file by flicking it.

Just add #define DEBUG at the top?

Yeah well, it's really just a reminder that there's DEBUG stuff in that
file, but feel free to send a patch removing it :-)

Ben.



-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/