Re: [Bugme-new] [Bug 9006] New: incorrect method to turn off DPLL in intel framebuffer driver

On Tue, 11 Sep 2007 00:40:22 -0700 (PDT) bugme-daemon@bugzilla.kernel.org wrote:

http://bugzilla.kernel.org/show_bug.cgi?id=9006

           Summary: incorrect method to turn off DPLL in intel framebuffer
                    driver
           Product: Platform Specific/Hardware
           Version: 2.5
     KernelVersion: 2.6.18.1
          Platform: All
        OS/Version: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: i386
        AssignedTo: platform_i386@kernel-bugs.osdl.org
        ReportedBy: william.pan@kontron.cn


in file intelfbhw.c, function intelfbhw_program_mode, the steps to 
turn off DPLL:
        tmp = INREG(dpll_reg);
        dpll_reg &= ~DPLL_VCO_ENABLE;
        OUTREG(dpll_reg, tmp);
guess it should be:
        tmp = INREG(dpll_reg);
        tmp &= ~DPLL_VCO_ENABLE;
        OUTREG(dpll_reg, tmp);
am I right?

?

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/