K Krzysztof Helt #
Message details and related content
From: Krzysztof Helt <redacted>
This patch replaces busy waiting with the cpu_relax() call.
This makes scrolling faster.
Signed-off-by: Krzysztof Helt <redacted>
---
This makes scrolling 25% faster (!) on Permedia2V and 333MHz CPU.
This patch is done against 2.6.23-rc4-mm1 tree.
--- linux-2.6.22/drivers/video/pm2fb.c 2007-09-05 21:55:45.214876598 +0200
+++ linux-2.6.23-mm/drivers/video/pm2fb.c 2007-09-05 21:57:40.997474673 +0200@@ -193,8 +193,8 @@ static inline void pm2v_RDAC_WR(struct p #else static inline void WAIT_FIFO(struct pm2fb_par *p, u32 a) { - while (pm2_RD(p, PM2R_IN_FIFO_SPACE) < a); - mb(); + while (pm2_RD(p, PM2R_IN_FIFO_SPACE) < a) + cpu_relax(); } #endif
@@ -328,7 +328,7 @@ static void reset_card(struct pm2fb_par pm2_WR(p, PM2R_RESET_STATUS, 0); mb(); while (pm2_RD(p, PM2R_RESET_STATUS) & PM2F_BEING_RESET) - ; + cpu_relax(); mb(); #ifdef CONFIG_FB_PM2_FIFO_DISCONNECT DPRINTK("FIFO disconnect enabled\n");
@@ -1041,8 +1041,7 @@ static int pm2fb_sync(struct fb_info *in mb(); do { while (pm2_RD(par, PM2R_OUT_FIFO_WORDS) == 0) - udelay(10); - rmb(); + cpu_relax(); } while (pm2_RD(par, PM2R_OUT_FIFO) != PM2TAG(PM2R_SYNC)); return 0; -------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/