Re: [PATCH] Intel FB pixel clock calculation fix
From: Andrew Morton <akpm@linux-foundation.org>
Date: 2007-09-11 05:52:39
Also in:
lkml
On Mon, 10 Sep 2007 21:24:42 +0200 Krzysztof Halasa [off-list ref] wrote:
quoted hunk
Intel framebuffer mis-calculated pixel clocks. Signed-off-by: Krzysztof Halasa <khc@pm.waw.pl>--- a/drivers/video/intelfb/intelfbhw.c +++ b/drivers/video/intelfb/intelfbhw.c@@ -924,10 +920,10 @@ calc_pll_params(int index, int clock, u32 *retm1, u32 *retm2, u32 *retn, u32 *re if (m > pll->max_m) m = pll->max_m - 1; for (testm = m - 1; testm <= m; testm++) { - f_out = calc_vclock3(index, m, n, p); + f_out = calc_vclock3(index, testm, n, p); if (splitm(index, testm, &m1, &m2)) { - WRN_MSG("cannot split m = %d\n", m); - n++; + WRN_MSG("cannot split m = %d\n", + testm); continue; } if (clock > f_out)
and... what are the consequences of this miscalculation? I need to know such things so that I can decide whether a change is needed in 2.6.23. And 2.6.22. Thanks. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/