Thread (4 messages) 4 messages, 2 authors, 2007-09-11

Re: [PATCH 2/4] radeonfb: add new module parameter to force PLL calculation

From: <hidden>
Date: 2007-09-10 22:19:11
Also in: lkml

On Tue, Sep 04, 2007 at 03:46:29PM +0200, Benjamin Herrenschmidt wrote:
I don't like those tunables. First we should get a look at what values
we obtain from the BIOS. Could be something with the parsing of ATOM
BIOS. In any case, we might be able to detect we got wrong values or use
subsystem vendor/device ID to blacklist.
So what should I looking for?
Here is the diff of the radeonfb kernel messages between 
(-)nopllcalc and (+)forcing pll calculation with my patch:

   vSync_width: 4
   clock: 7350
 Setting up default mode based on panel info
-hStart = 672, hEnd = 712, hTotal = 824
-vStart = 404, vEnd = 408, vTotal = 437
-h_total_disp = 0x4f0066           hsync_strt_wid = 0x5029a
-v_total_disp = 0x18f01b4          vsync_strt_wid = 0x40193
+hStart = 1312, hEnd = 1352, hTotal = 1464
+vStart = 804, vEnd = 808, vTotal = 837
+h_total_disp = 0x9f00b6           hsync_strt_wid = 0x5051a
+v_total_disp = 0x31f0344          vsync_strt_wid = 0x40323
 pixclock = 13605
 freq = 7350
-Console: switching to colour frame buffer device 80x25
+freq = 7350, PLL min = 20000, PLL max = 40000
+ref_div = 6, ref_clk = 1432, output_freq = 29400
+ref_div = 6, ref_clk = 1432, output_freq = 29400
+post div = 0x2
+fb_div = 0x7b
+ppll_div_3 = 0x2007b
+Console: switching to colour frame buffer device 160x50
 radeonfb (0000:01:05.0): ATI Radeon 5975 "Yu"
 radeonfb_pci_register END

"nopllcalc" results in a console 80x25 but forcing pll calculation gives
the expected result.

BTW, I am a little surprised that the display doesn't blank without
my patch as it used to in the past ...

  Oops, PCI ID 0x5975 was already added with commit
  b5f2f4d1a6d7efde39cfb5e1d034981c69f2214c

I guess I have to repeat some testing with both the older commit and my patch(es)
to sort out what is really needed to support my RS482/0x5975.


Regards,

Andreas


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help