Re: [PATCH] uvesafb: select connector in Kconfig

From
Michal Januszewski <spock@gentoo.org>
Date
2007-08-26 09:44:22
Also in
lkml
Reply to
Randy Dunlap, 2007-08-25
On Sat, Aug 25, 2007 at 08:23:41AM -0700, Randy Dunlap wrote:
There are 2 problems with this.

a.  CONNECTOR depends on NET, but select won't enable NET, so if
NET is not enabled otherwise, CONNECTOR still won't build.
This is a longstanding select/kconfig issue.

b.  CONNECTOR depends on NET, so if select did follow the depends
chain and enable NET, it would be enabling the networking subsystem,
which is something that should not be done quietly.

select should only be used for enabling small library-like code
(if even then).  Avoid it whenever possible.
OK, thanks for pointing this out.  Let's keep the original dependency
on CONNECTOR then.

Best regards,
Michal

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
Thread (3 messages) 3 messages, 2 authors, last reply 2007-08-26
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help