Re: [Linux-fbdev-devel] [PATCH] fbdev: find mode with highest refresh rate in fb_find_mode()

From
Antonino A. Daplas <adaplas@gmail.com>
Date
2007-07-18 15:18:29
Also in
lkml
Reply to
Ondrej Zajicek, 2007-07-18
On Wed, 2007-07-18 at 16:38 +0200, Ondrej Zajicek wrote:
On Wed, Jul 18, 2007 at 10:41:02AM +0200, Michal Januszewski wrote:
quoted
Currently if the refresh rate is not specified fb_find_mode() returns
the first known video mode with the requested resoluion, which provides
no guarantees wrt the refresh rate.  Change this so that the mode with
the highest refresh rate is returned instead.
What refresh rate it sets when used on card or monitor without DDC?
Yes, I noted this also while reviewing patches.  fb_find_mode() is used
predominantly with the 'generic' modedb which contains modes that are
not specific to the card or monitor.  And fb_try_mode() is not a
guarantee that the returned refresh rate will be safe (we have a lot of
drivers that do not check the timings against the display capabilities).

It would be best that fb_find_mode() return the safest refresh rate
(60Hz) instead of the highest.

Tony
Thread (6 messages) 6 messages, 3 authors, last reply 2007-08-29
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help