Re: [PATCH 03/33] s3c2410fb: fix s3c2410 compilation
From: Andrew Morton <akpm@linux-foundation.org>
Date: 2007-07-26 20:03:52
On Thu, 26 Jul 2007 19:47:57 +0800 "Antonino A. Daplas" [off-list ref] wrote:
quoted hunk ↗ jump to hunk
@@ -680,6 +681,7 @@ static inline void modify_gpio(void __io static int s3c2410fb_init_registers(struct s3c2410fb_info *fbi) { unsigned long flags; + void __iomem *regs = fbi->io; /* Initialise LCD with values from haret */@@ -694,25 +696,25 @@ static int s3c2410fb_init_registers(stru local_irq_restore(flags);
What are the local_irq_save/restore calls in this driver doing? Either something subtle is happening, or it is wrong on SMP. If it's an only-ever-on-UP driver then spin_lock_irqsave() would be better: it'll deveolve to local_irq_save() anyway. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/