Thread (3 messages) 3 messages, 2 authors, 2007-07-26

typo errors in the modedb.c video mode tables

flat view

From: John Lumby <hidden>
Date: 2007-07-21 22:59:37

I believe there are a few typos in the mode tables in modedb.c   -   in the 
current 2.6.22 :

  .  line 77
	/* 1152x864 @ 89 Hz interlaced, 44 kHz hsync */
	NULL, 69, 1152, 864, 15384, 96, 16, 110, 1, 216, 10,
should be
	/* 1152x864 @ 89 Hz interlaced, 44 kHz hsync */
	NULL, 89, 1152, 864, 15384, 96, 16, 110, 1, 216, 10,

. line 125

	/* 1400x1050 @ 60Hz, 63.9 kHz hsync */
	NULL, 68, 1400, 1050, 9259, 136, 40, 13, 1, 112, 3,
should be
	/* 1400x1050 @ 60Hz, 63.9 kHz hsync */
	NULL, 60, 1400, 1050, 9259, 136, 40, 13, 1, 112, 3,

. line 129
	/* 1400x1050 @ 75,107 Hz, 82,392 kHz +hsync +vsync*/
	NULL, 75, 1400, 1050, 9271, 120, 56, 13, 0, 112, 3,
is wrong somewhere but I don't know what should be changed

. line 258
	/* 1152x768, 60 Hz, PowerBook G4 Titanium I and II */
	NULL, 60, 1152, 768, 15386, 158, 26, 29, 3, 136, 6,
is wrong somewhere but I don't know what should be changed

. line 311
        /* 12 1024x768i-43 VESA */
	{ NULL, 53, 1024, 768, 22271, 56, 8, 41, 0, 176, 8,
should be
        /* 12 1024x768i-43 VESA */
	{ NULL, 43, 1024, 768, 22271, 56, 8, 41, 0, 176, 8,

. line 388
	/* 33 1920x1440-75 VESA */
	{ NULL, 60, 1920, 1440, 3367, 352, 144, 56, 1, 224, 3,
should be
	/* 33 1920x1440-75 VESA */
	{ NULL, 75, 1920, 1440, 3367, 352, 144, 56, 1, 224, 3,

In the cases where I've stated the correction, in every case it's the v_sync 
refresh rate which is wrong and it's pretty obvious as the preceding comment 
has the correct value.      In the other cases, I'm not sure but my 
calculations indicates the refresh is not consistent with the other values 
(but I could be wrong).

I also don't know what effect these errors are having - I found them from 
studying the code after I could not get my desired 1400x1050@60 for my 
supersavage framebuffer console.       One of the above entries is the one I 
want.    Is the refresh value in these tables used for matching modes?      
It seems so from my reading of fb_find_mode() in the same file.

John

_________________________________________________________________
Tell us your tech love story in the Summer Lovin Competition for your chance 
to win laptop loaded with Windows Vista, Office 2007 and Windows Live 
OneCare. 
http://www.microsoft.com/canada/home/contests/summerlovin/default.aspx


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help