OMAP: Add TI OMAP framebuffer driver

Started by Trilok Soni on Jun 26, 2007 · 3 messages from 2 authors · Last reply Jun 27, 2007

STALE7084d

open the first message on its own page

Message details and related content
diff --git a/drivers/video/omap/Makefile b/drivers/video/omap/Makefile
new file mode 100644
index 0000000..5aa7175
--- /dev/null
+++ b/drivers/video/omap/Makefile
@@ -0,0 +1,10 @@
+#
+# Makefile for the new OMAP framebuffer device driver
+#
+
+obj-$(CONFIG_FB_OMAP) += omapfb.o
+
+objs-yy := omapfb_main.o
+
+omapfb-objs := $(objs-yy)
+
This looks strangs.
Please use:
obj-$(CONFIG_FB_OMAP) += omapfb.o

omapfb-y := omapfb_main.o

Or even better rename your .c file to omapfb.c then
you only need to use:
obj-$(CONFIG_FB_OMAP) += omapfb.o

	Sam
Message details and related content
Hi Sam,

On 6/26/07, Sam Ravnborg [off-list ref] wrote:
quoted hunk
diff --git a/drivers/video/omap/Makefile b/drivers/video/omap/Makefile
new file mode 100644
index 0000000..5aa7175
--- /dev/null
+++ b/drivers/video/omap/Makefile
@@ -0,0 +1,10 @@
+#
+# Makefile for the new OMAP framebuffer device driver
+#
+
+obj-$(CONFIG_FB_OMAP) += omapfb.o
+
+objs-yy := omapfb_main.o
+
+omapfb-objs := $(objs-yy)
+
This looks strangs.
Please use:
obj-$(CONFIG_FB_OMAP) += omapfb.o

omapfb-y := omapfb_main.o

Or even better rename your .c file to omapfb.c then
you only need to use:
obj-$(CONFIG_FB_OMAP) += omapfb.o
Thanx for the review. I will incorporate your suggestions into the
next update of fb patches.

-- 
--Trilok Soni

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help