Re: [PATCH 10/10] [HEADS UP] fbdev: Move arch-specific bits to their respective subdirectories
From: David Miller <davem@davemloft.net>
Date: 2007-05-17 20:30:38
Also in:
lkml
From: "Antonino A. Daplas" <adaplas@gmail.com> Date: Thu, 17 May 2007 18:51:22 +0800
On Thu, 2007-05-17 at 10:49 +0100, Christoph Hellwig wrote:quoted
On Thu, May 17, 2007 at 05:33:48AM +0800, Antonino A. Daplas wrote:quoted
-#if defined(__sparc__) && !defined(__sparc_v9__) - /* Should never get here, all fb drivers should have their own - mmap routines */ - return -EINVAL; -#else - /* !sparc32... */ + if (fb_mmap_required()) + return -EINVAL; +I don't like this bit.Me too, actually. I did it this way because I don't want to deviate from the old code too much. Since all sparc32 drivers are either linked to sbuslib.c or has their own fb_mmap method, the above test is redundant. I'll leave the decision to remove the above test to David Miller.
Feel free to remove it. ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/