fbdev: Add support for AVR32

Started by Haavard Skinnemoen on May 7, 2007 · 4 messages from 3 authors · Last reply May 7, 2007

Subsystems (2)

Maintainers (2)

STALE7136d

open the first message on its own page

Message details and related content
Provide framebuffer page protection flags and definitions of
fb_readl/fb_writel for AVR32.

Signed-off-by: Haavard Skinnemoen <redacted>
---
Please let me know if you want me to push this myself through the
AVR32 tree.

 drivers/video/fbmem.c |    4 ++++
 include/linux/fb.h    |    2 +-
 2 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/drivers/video/fbmem.c b/drivers/video/fbmem.c
index 2822526..babf8a9 100644
--- a/drivers/video/fbmem.c
+++ b/drivers/video/fbmem.c
@@ -1198,6 +1198,10 @@ fb_mmap(struct file *file, struct vm_area_struct * vma)
 	pgprot_val(vma->vm_page_prot) |= _PAGE_NO_CACHE;
 #elif defined(__arm__) || defined(__sh__) || defined(__m32r__)
 	vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot);
+#elif defined(__avr32__)
+	vma->vm_page_prot = __pgprot((pgprot_val(vma->vm_page_prot)
+				      & ~_PAGE_CACHABLE)
+				     | (_PAGE_BUFFER | _PAGE_DIRTY));
 #elif defined(__ia64__)
 	if (efi_range_is_wc(vma->vm_start, vma->vm_end - vma->vm_start))
 		vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot);
diff --git a/include/linux/fb.h b/include/linux/fb.h
index be913ec..deb2365 100644
--- a/include/linux/fb.h
+++ b/include/linux/fb.h
@@ -833,7 +833,7 @@ struct fb_info {
 #define fb_writeq sbus_writeq
 #define fb_memset sbus_memset_io
 
-#elif defined(__i386__) || defined(__alpha__) || defined(__x86_64__) || defined(__hppa__) || (defined(__sh__) && !defined(__SH5__)) || defined(__powerpc__)
+#elif defined(__i386__) || defined(__alpha__) || defined(__x86_64__) || defined(__hppa__) || (defined(__sh__) && !defined(__SH5__)) || defined(__powerpc__) || defined(__avr32__)
 
 #define fb_readb __raw_readb
 #define fb_readw __raw_readw
-- 
1.4.4.4
Message details and related content
From: Haavard Skinnemoen <redacted>
Date: Mon,  7 May 2007 17:20:33 +0200
Provide framebuffer page protection flags and definitions of
fb_readl/fb_writel for AVR32.

Signed-off-by: Haavard Skinnemoen <redacted>
This isn't directed to you specifically, I'm just making a general
comment.

We're at the point where these two snippets of code in the fb layer
are a total mess of ifdefs.

It's time we made an include/asm-foo/fb.h header file and abstracted
out the necessary details there.

Re: [Linux-fbdev-devel] [PATCH] fbdev: Add support for AVR32

Message details and related content
On Mon, 2007-05-07 at 13:47 -0700, David Miller wrote:
From: Haavard Skinnemoen <redacted>
Date: Mon,  7 May 2007 17:20:33 +0200
We're at the point where these two snippets of code in the fb layer
are a total mess of ifdefs.

It's time we made an include/asm-foo/fb.h header file and abstracted
out the necessary details there.
I agree. I'll start working on this.

Tony

Re: [Linux-fbdev-devel] [PATCH] fbdev: Add support for AVR32

Message details and related content
From: "Antonino A. Daplas" <adaplas@gmail.com>
Date: Tue, 08 May 2007 06:55:52 +0800
On Mon, 2007-05-07 at 13:47 -0700, David Miller wrote:
quoted
From: Haavard Skinnemoen <redacted>
Date: Mon,  7 May 2007 17:20:33 +0200
quoted
We're at the point where these two snippets of code in the fb layer
are a total mess of ifdefs.

It's time we made an include/asm-foo/fb.h header file and abstracted
out the necessary details there.
I agree. I'll start working on this.

Tony
Thanks a lot Tony.
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help