Re: [PATCH] Move declaration of fb_class to <linux/fb.h>
From: James Simmons <hidden>
Date: 2007-05-24 14:05:44
On Thu, 24 May 2007, Geert Uytterhoeven wrote:
quoted hunk ↗ jump to hunk
Move the forward declaration of fb_class from drivers/video/console/fbcon.h to <linux/fb.h>, together with the other forward declarations related to drivers/video/fbmem.c. This kills the following sparse warning: | drivers/video/fbmem.c:1363:14: warning: symbol 'fb_class' was not declared. Should it be static? Signed-off-by: Geert Uytterhoeven <redacted> --- drivers/video/console/fbcon.h | 1 - include/linux/fb.h | 1 + 2 files changed, 1 insertion(+), 1 deletion(-)--- a/drivers/video/console/fbcon.h +++ b/drivers/video/console/fbcon.h@@ -176,7 +176,6 @@ extern void fbcon_set_tileops(struct vc_ #endif extern void fbcon_set_bitops(struct fbcon_ops *ops); extern int soft_cursor(struct fb_info *info, struct fb_cursor *cursor); -extern struct class *fb_class; #define FBCON_ATTRIBUTE_UNDERLINE 1 #define FBCON_ATTRIBUTE_REVERSE 2 --- a/include/linux/fb.h +++ b/include/linux/fb.h@@ -942,6 +942,7 @@ extern int fb_new_modelist(struct fb_inf extern struct fb_info *registered_fb[FB_MAX]; extern int num_registered_fb; +extern struct class *fb_class; static inline void __fb_pad_aligned_buffer(u8 *dst, u32 d_pitch, u8 *src, u32 s_pitch, u32 height)
I haven't looked at the sysfs handling until now. What a mess!!! Fbcon is using class_device instead of a regular device. It needs a cleanup. Last time I sent a sysfs patch it was ignored which didn't give me much motivation to resend it. I will resend it with improvements to fbcon if tony doesn't blow it off this time. ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/