Re: [PATCH 2/5] viafb: Framebuffer driver for VIA UniChrome/Chrome9 HC
From: "Antonino A. Daplas" <adaplas@gmail.com>
Date: 2007-04-29 12:38:13
On Sat, 2007-04-28 at 10:42 +0800, EddyFu@via.com.tw wrote: We did not receive patch 1 and patch 5. Most probably, they exceeded the size of attachment limit.
quoted hunk ↗ jump to hunk
diff -Nur linux-2.6.21-rc7/drivers/video/via/hwcfig.h linux-2.6.21-rc7.viafb/drivers/video/via/hwcfig.h--- linux-2.6.21-rc7/drivers/video/via/hwcfig.h 1969-12-3119:00:00.000000000 -0500+++ linux-2.6.21-rc7.viafb/drivers/video/via/hwcfig.h 2007-04-2619:52:32.000000000 -0400@@ -0,0 +1,399 @@ + /* + * Copyright 1998-2007 VIA Technologies, Inc. All Rights Reserved. + * Copyright 2001-2007 S3 Graphics, Inc. All Rights Reserved. + * + * Permission is hereby granted, free of charge, to any personobtaining a + * copy of this software and associated documentation files (the "Software"), + * to deal in the Software without restriction, including without limitation + * the rights to use, copy, modify, merge, publish, distribute, sub license, + * and/or sell copies of the Software, and to permit persons to whom the + * Software is furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice (including the + * next paragraph) shall be included in all copies or substantial portions + * of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL + * THE AUTHOR(S) OR COPYRIGHT HOLDER(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR + * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, + * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER + * DEALINGS IN THE SOFTWARE. + */
Athough the text looks like X-MIT, and is therefore GPL compatible, I (and Linus) would prefer an explicit note stating GPL compatibility. And a Signed-off-by: (especially since the copyright owner is VIA and S3). Until we receive the entire patch series, I will refrain from commenting on this. Tony
------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/