Thread (13 messages) 13 messages, 2 authors, 2007-04-27

Re: Console unregistration questions

From: Jesse Barnes <hidden>
Date: 2007-04-24 23:46:41

On Tuesday, April 24, 2007, Antonino A. Daplas wrote:
quoted
quoted
 Also, shouldn't callers of
unregister_con_driver be checking return values?  That would have
made this bug a lot easier to find at least. :)
Replying to myself:

At this point, if unregister_con_driver() fails, it is too late for
fbcon, the best thing to do is issue a BUG().
I guess there's no way to propagate the error back to 
unregister_framebuffer?  If we did, then it could return -EBUSY or 
something, keeping the module loaded instead of unsafely allowing it to be 
removed...
However, I'll add extra code to unregister_framebuffer() that will check
if it's safe for the driver to unload.  The drivers may then choose to
check it or not.
Sounds good.

Jesse

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help