fix pixclock setting on Voodoo 1/2 cards

Started by Ondrej Zajicek on Mar 7, 2007

DORMANTno replies

open the first message on its own page

Message details and related content
Pixclock setting in sstfb didn't work with my Voodoo 2 card
with ICS 5342 DAC (this DAC requires two consecutive writes
to one of its registers to program pixclock - maybe first
write merged with second).

This patch fixes bug with pixclock setting. It is against 
2.6.21-rc1 .

Signed-off-by: Ondrej Zajicek <redacted>

---

diff -uprN -X linux-2.6.21-rc1-not/Documentation/dontdiff linux-2.6.21-rc1-not/drivers/video/sstfb.c linux-2.6.21-rc1-fix/drivers/video/sstfb.c
--- linux-2.6.21-rc1-not/drivers/video/sstfb.c	2007-02-04 19:44:54.000000000 +0100
+++ linux-2.6.21-rc1-fix/drivers/video/sstfb.c	2007-03-07 21:03:08.000000000 +0100
@@ -257,6 +257,7 @@ static void __sst_dac_write(u8 __iomem *
 	r_dprintk("sst_dac_write(%#x, %#x)\n", reg, val);
 	reg &= 0x07;
 	__sst_write(vbase, DAC_DATA,(((u32)reg << 8)) | (u32)val);
+	__sst_wait_idle(vbase);
 }
 
 /* indexed access to ti/att dacs */

-- 
Ondrej 'SanTiago' Zajicek (email: santiago@mail.cz, jabber: santiago@njs.netlab.cz)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help