Thread (5 messages) 5 messages, 4 authors, 2007-03-07

Re: [stable] [PATCH] atyfb: Replace busy loop with mdelay()

From: Greg KH <hidden>
Date: 2007-03-07 01:15:37

On Tue, Mar 06, 2007 at 02:29:43AM +0200, Ville Syrj?l? wrote:
On Mon, Mar 05, 2007 at 03:53:18PM -0800, Andrew Morton wrote:
quoted
@@ -614,7 +613,7 @@ static void aty_resume_pll_ct(const stru
                 * helps for Rage Mobilities that sometimes crash when
                 * we switch to sclk. (Daniel Mantione, 13-05-2003)
                 */
-               for (i=0;i<=0x1ffff;i++);
+               udelay(500);
I'm not sure if 500 us is enough. The programmer's guide says you should 
allow 5 ms for the PLL to lock.
Then can you correct the patch in mainline, and forward what gets
accepted there to the stable team if you wish the change to also be made
there?

thanks,

greg k-h

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help