A Andrew Morton #
Message details and related content
Begin forwarded message: Date: Sun, 4 Mar 2007 22:12:42 -0800 From: <redacted> To: <redacted> Subject: [Bugme-new] [Bug 8129] New: kyrofb_check_var misses x-resolution and y-resolution setting? http://bugzilla.kernel.org/show_bug.cgi?id=8129 Summary: kyrofb_check_var misses x-resolution and y-resolution setting? Kernel Version: Linux 2.6.20 Status: NEW Severity: normal Owner: jsimmons@infradead.org Submitter: shanlu@cs.uiuc.edu Distribution: Linux 2.6.20 Problem Description: kyrofb_check_var (the function supposed to set up based video mode) seems to forget set two framebuffer parameters: x-resolution and y-resolution. The function is in File drivers/video/kyro/fbdev.c 399 static int kyrofb_check_var(struct fb_var_screeninfo *var, struct fb_info *info) 400 { 401 struct kyrofb_info *par = info->par; ... In above function, almost every display-related fields (upper-margin, left-margin, sync, etc.) are set for var based on info->par. But var->x_res and var->y_res (x-resolution and y-resolution) are not. Why not use par->XRES and par->YRES to set it? Also the par->X_RES and par->Y_RES do get set in kyrofb_set_par (in the same file), together with other field like par->HFP (right margin), HBP (left_margin). I think check_var should take x,y-resolution from par. ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV